Add raw ID field filtering for polymorphic models #765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #765 +/- ##
==========================================
+ Coverage 84.09% 84.13% +0.03%
==========================================
Files 27 28 +1
Lines 1610 1639 +29
Branches 253 258 +5
==========================================
+ Hits 1354 1379 +25
- Misses 195 198 +3
- Partials 61 62 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bckohan
force-pushed
the
foreignkeyrawwidget
branch
from
0957152 to
be67398
Compare
bckohan
force-pushed
the
foreignkeyrawwidget
branch
from
be67398 to
a9614d8
Compare
Collaborator
|
I'm closing the related issue as won't fix. This convenience function is either too specific to the user or has been fixed. I have tested the scenario where child models A and B have M2M fields to each other and the raw ids correctly only show A or Bs respectively. The user may have put a self referential M2M relationship in the base class and in that case showing ids for all child model types is correct behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements automatic filtering of popup change lists for raw ID fields when they point to polymorphic models.
Closes #144